Best way to farm wow money?

Making money comes in quite a few different forms. And doing ONE of them usually isnt the best way.

I suggest doing a quick daily run up on the Isle. You will make 100 gold in an hour. Not a bad start for the day. From there, take your preferred profession on the road. If you are mining, remember that Iron/Mithril are still very valuable and often times it will earn you more money per hour than farming Fel Iron +. While you do have a chance to pull out some Motes of Fire while farming the higher tier stuff, its up to you which you would prefer doing.

Herbalism will net you cash too. Not much anymore though because Wrath is on the horizon and everyone that has powerleveld inscription hs already done so. Raiding is at a halt on most servers because nobody cares anymore. So flasks arent as expensive as they once were.

Skinning is always a seller. It hardly ever puts the gold out that the other two gathering professions do, but it sells easier imo.

With the acheivment system comes 2 easy ways to make money.
1) People wanting the Ambassador title. Farm + Sell Runecloth. On Icecrown Im selling stacks for 10 gold. Not bad at all considering how fast and easy it is to farm.

2) Cooking achievments. Tons of people are leveling cooking because it is easy. They just dont want to farm the mats for it. Neither do I. But fishing supplements cooking and you can rake in some easy cash from an hour of fishing at.. almost any level.

As far as farming primals, its pretty moot now. Nobody needs the Primal shadows now because if a guild is still learning Sharaz, whats the point? You dont even need the SR now, most guilds with a decent chunk of DPS can down her in a minute. That includes Tier 5 guilds. Primal lifes arent really work farming either (taking from my server). The price dropped from 15-20 gold to 5-7 gold per Primal. Waters + Air's wont sell as well either. They are mostly used in crafting recipe's and people dont much care to make those now that wratch is coming in less than a week.

So as far as primals go, I wouldnt even worry about those. If you pick some up, bonus... but dont farm for them.

You can still farm greens at low levels and sell them on the AH for insane prices. Level 57 greens go for a lot on my server.

Whatever you do, try to do a combination of 1-2-3 things instead of just 1.